Re: [PATCH v4 3/6] hwmon: scmi: update hwmon internal scale data type

[Guenter Roeck]

On Thu, Nov 19, 2020 at 05:49:03PM +0000, Cristian Marussi wrote:
> Use an int to calculate scale values inside scmi_hwmon_scale() to match
> the updated scale data type in struct scmi_sensor_info.
> 
> Cc: linux-hwmon@xxxxxxxxxxxxxxx
> Cc: Guenter Roeck <linux@xxxxxxxxxxxx>
> Signed-off-by: Cristian Marussi <cristian.marussi@xxxxxxx>

Acked-by: Guenter Roeck <linux@xxxxxxxxxxxx>

[ Assuming this will be pushed togesther with the other patches in the series ]

Guenter

> ---
>  drivers/hwmon/scmi-hwmon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/scmi-hwmon.c b/drivers/hwmon/scmi-hwmon.c
> index 09ce30cba54b..17d064e58938 100644
> --- a/drivers/hwmon/scmi-hwmon.c
> +++ b/drivers/hwmon/scmi-hwmon.c
> @@ -30,7 +30,7 @@ static inline u64 __pow10(u8 x)
>  
>  static int scmi_hwmon_scale(const struct scmi_sensor_info *sensor, u64 *value)
>  {
> -	s8 scale = sensor->scale;
> +	int scale = sensor->scale;
>  	u64 f;
>  
>  	switch (sensor->type) {
> -- 
> 2.17.1
>