Re: [PATCH 4.9 00/16] 4.9.245-rc1 review

From: Greg Kroah-Hartman
Date: Sun Nov 22 2020 - 03:01:45 EST

Next message: Christian Eggers: "[PATCH net-next 0/3] net: ptp: use common defines for PTP message types in further drivers"
Previous message: Greg Kroah-Hartman: "Re: [PATCH 4.4 00/15] 4.4.245-rc1 review"
In reply to: Guenter Roeck: "Re: [PATCH 4.9 00/16] 4.9.245-rc1 review"
Next in thread: Naresh Kamboju: "Re: [PATCH 4.9 00/16] 4.9.245-rc1 review"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Sat, Nov 21, 2020 at 10:34:46AM -0800, Guenter Roeck wrote:
> On Fri, Nov 20, 2020 at 12:03:05PM +0100, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 4.9.245 release.
> > There are 16 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Sun, 22 Nov 2020 10:45:32 +0000.
> > Anything received after that time might be too late.
> >
>
> Build results:
> total: 168 pass: 166 fail: 2
> Failed builds:
> powerpc:cell_defconfig
> powerpc:maple_defconfig
> Qemu test results:
> total: 382 pass: 377 fail: 5
> Failed tests:
> ppc64:mac99:ppc64_book3s_defconfig:smp:initrd
> ppc64:mac99:ppc64_book3s_defconfig:smp:ide:rootfs
> ppc64:mac99:ppc64_book3s_defconfig:smp:sdhci:mmc:rootfs
> ppc64:mac99:ppc64_book3s_defconfig:smp:nvme:rootfs
> ppc64:mac99:ppc64_book3s_defconfig:smp:scsi[DC395]:rootfs
>
> Build failures see below. Note that the failures are different than the
> failures observed in the v4.4.y release candidate, meaning that some
> additional errors may not be reported.
>
> Tested-by: Guenter Roeck <linux@xxxxxxxxxxxx>
>
> Guenter
>
> ---
> Building powerpc:cell_defconfig ... failed
> --------------
> Error log:
> In file included from arch/powerpc/include/asm/kup.h:10:0,
> from arch/powerpc/include/asm/uaccess.h:12,
> from arch/powerpc/lib/checksum_wrappers.c:24:
> arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: error: data definition has no type or storage class [-Werror]
> DECLARE_STATIC_KEY_FALSE(uaccess_flush_key);
> ^~~~~~~~~~~~~~~~~~~~~~~~
> arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: error: type defaults to ‘int’ in declaration of ‘DECLARE_STATIC_KEY_FALSE’ [-Werror=implicit-int]
> arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: error: parameter names (without types) in function declaration [-Werror]
> arch/powerpc/include/asm/book3s/64/kup-radix.h: In function ‘prevent_user_access’:
> arch/powerpc/include/asm/book3s/64/kup-radix.h:18:6: error: implicit declaration of function ‘static_branch_unlikely’ [-Werror=implicit-function-declaration]
> if (static_branch_unlikely(&uaccess_flush_key))
> ^~~~~~~~~~~~~~~~~~~~~~
> arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: error: ‘uaccess_flush_key’ undeclared (first use in this function); did you mean ‘do_uaccess_flush’?
> if (static_branch_unlikely(&uaccess_flush_key))
> ^~~~~~~~~~~~~~~~~
> do_uaccess_flush
> arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: note: each undeclared identifier is reported only once for each function it appears in
> cc1: all warnings being treated as errors
> make[2]: *** [arch/powerpc/lib/checksum_wrappers.o] Error 1
> make[2]: *** Waiting for unfinished jobs....
> make[2]: *** wait: No child processes. Stop.
> make[1]: *** [arch/powerpc/lib] Error 2
> make[1]: *** Waiting for unfinished jobs....
> In file included from arch/powerpc/include/asm/kup.h:10:0,
> from arch/powerpc/include/asm/uaccess.h:12,
> from arch/powerpc/platforms/cell/spufs/syscalls.c:8:
> arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: error: data definition has no type or storage class [-Werror]
> DECLARE_STATIC_KEY_FALSE(uaccess_flush_key);
> ^~~~~~~~~~~~~~~~~~~~~~~~
> arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: error: type defaults to ‘int’ in declaration of ‘DECLARE_STATIC_KEY_FALSE’ [-Werror=implicit-int]
> arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: error: parameter names (without types) in function declaration [-Werror]
> arch/powerpc/include/asm/book3s/64/kup-radix.h: In function ‘prevent_user_access’:
> arch/powerpc/include/asm/book3s/64/kup-radix.h:18:6: error: implicit declaration of function ‘static_branch_unlikely’ [-Werror=implicit-function-declaration]
> if (static_branch_unlikely(&uaccess_flush_key))
> ^~~~~~~~~~~~~~~~~~~~~~
> arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: error: ‘uaccess_flush_key’ undeclared (first use in this function); did you mean ‘do_uaccess_flush’?
> if (static_branch_unlikely(&uaccess_flush_key))
> ^~~~~~~~~~~~~~~~~
> do_uaccess_flush
> arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: note: each undeclared identifier is reported only once for each function it appears in
> cc1: all warnings being treated as errors
> make[4]: *** [arch/powerpc/platforms/cell/spufs/syscalls.o] Error 1
> make[4]: *** Waiting for unfinished jobs....
> In file included from arch/powerpc/include/asm/kup.h:10:0,
> from arch/powerpc/include/asm/uaccess.h:12,
> from include/linux/uaccess.h:8,
> from include/linux/crypto.h:26,
> from crypto/cipher.c:17:
> arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: warning: data definition has no type or storage class
> DECLARE_STATIC_KEY_FALSE(uaccess_flush_key);
> ^~~~~~~~~~~~~~~~~~~~~~~~
> arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: error: type defaults to ‘int’ in declaration of ‘DECLARE_STATIC_KEY_FALSE’ [-Werror=implicit-int]
> arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: warning: parameter names (without types) in function declaration
> arch/powerpc/include/asm/book3s/64/kup-radix.h: In function ‘prevent_user_access’:
> arch/powerpc/include/asm/book3s/64/kup-radix.h:18:6: error: implicit declaration of function ‘static_branch_unlikely’ [-Werror=implicit-function-declaration]
> if (static_branch_unlikely(&uaccess_flush_key))
> ^~~~~~~~~~~~~~~~~~~~~~
> arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: error: ‘uaccess_flush_key’ undeclared (first use in this function); did you mean ‘do_uaccess_flush’?
> if (static_branch_unlikely(&uaccess_flush_key))
> ^~~~~~~~~~~~~~~~~
> do_uaccess_flush
> arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: note: each undeclared identifier is reported only once for each function it appears in
> In file included from arch/powerpc/include/asm/kup.h:10:0,
> from arch/powerpc/include/asm/uaccess.h:12,
> from include/linux/uaccess.h:8,
> from include/linux/crypto.h:26,
> from crypto/compress.c:15:
> arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: warning: data definition has no type or storage class
> DECLARE_STATIC_KEY_FALSE(uaccess_flush_key);
> ^~~~~~~~~~~~~~~~~~~~~~~~
> arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: error: type defaults to ‘int’ in declaration of ‘DECLARE_STATIC_KEY_FALSE’ [-Werror=implicit-int]
> arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: warning: parameter names (without types) in function declaration
> cc1: some warnings being treated as errors
> make[2]: *** [crypto/cipher.o] Error 1
> make[2]: *** Waiting for unfinished jobs....
> arch/powerpc/include/asm/book3s/64/kup-radix.h: In function ‘prevent_user_access’:
> arch/powerpc/include/asm/book3s/64/kup-radix.h:18:6: error: implicit declaration of function ‘static_branch_unlikely’ [-Werror=implicit-function-declaration]
> if (static_branch_unlikely(&uaccess_flush_key))
> ^~~~~~~~~~~~~~~~~~~~~~
> arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: error: ‘uaccess_flush_key’ undeclared (first use in this function); did you mean ‘do_uaccess_flush’?
> if (static_branch_unlikely(&uaccess_flush_key))
> ^~~~~~~~~~~~~~~~~
> do_uaccess_flush
> arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: note: each undeclared identifier is reported only once for each function it appears in
> In file included from arch/powerpc/include/asm/kup.h:10:0,
> from arch/powerpc/include/asm/uaccess.h:12,
> from include/asm-generic/termios-base.h:7,
> from arch/powerpc/include/asm/termios.h:20,
> from include/uapi/linux/termios.h:5,
> from include/linux/tty.h:6,
> from kernel/signal.c:18:
> arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: warning: data definition has no type or storage class
> DECLARE_STATIC_KEY_FALSE(uaccess_flush_key);
> ^~~~~~~~~~~~~~~~~~~~~~~~
> arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: error: type defaults to ‘int’ in declaration of ‘DECLARE_STATIC_KEY_FALSE’ [-Werror=implicit-int]
> arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: warning: parameter names (without types) in function declaration
> arch/powerpc/include/asm/book3s/64/kup-radix.h: In function ‘prevent_user_access’:
> arch/powerpc/include/asm/book3s/64/kup-radix.h:18:6: error: implicit declaration of function ‘static_branch_unlikely’ [-Werror=implicit-function-declaration]
> if (static_branch_unlikely(&uaccess_flush_key))
> ^~~~~~~~~~~~~~~~~~~~~~
> arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: error: ‘uaccess_flush_key’ undeclared (first use in this function); did you mean ‘do_uaccess_flush’?
> if (static_branch_unlikely(&uaccess_flush_key))
> ^~~~~~~~~~~~~~~~~
> do_uaccess_flush
> arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: note: each undeclared identifier is reported only once for each function it appears in
> In file included from arch/powerpc/include/asm/kup.h:10:0,
> from arch/powerpc/include/asm/uaccess.h:12,
> from include/linux/uaccess.h:8,
> from include/linux/crypto.h:26,
> from include/crypto/algapi.h:15,
> from crypto/memneq.c:62:
> arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: warning: data definition has no type or storage class
> DECLARE_STATIC_KEY_FALSE(uaccess_flush_key);
> ^~~~~~~~~~~~~~~~~~~~~~~~
> arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: error: type defaults to ‘int’ in declaration of ‘DECLARE_STATIC_KEY_FALSE’ [-Werror=implicit-int]
> arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: warning: parameter names (without types) in function declaration
> arch/powerpc/include/asm/book3s/64/kup-radix.h: In function ‘prevent_user_access’:
> arch/powerpc/include/asm/book3s/64/kup-radix.h:18:6: error: implicit declaration of function ‘static_branch_unlikely’ [-Werror=implicit-function-declaration]
> if (static_branch_unlikely(&uaccess_flush_key))
> ^~~~~~~~~~~~~~~~~~~~~~
> arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: error: ‘uaccess_flush_key’ undeclared (first use in this function); did you mean ‘do_uaccess_flush’?
> if (static_branch_unlikely(&uaccess_flush_key))
> ^~~~~~~~~~~~~~~~~
> do_uaccess_flush
> arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: note: each undeclared identifier is reported only once for each function it appears in
> cc1: some warnings being treated as errors
>
> Building powerpc:maple_defconfig ... failed
> --------------
> Error log:
> In file included from arch/powerpc/include/asm/kup.h:10:0,
> from arch/powerpc/include/asm/uaccess.h:12,
> from arch/powerpc/lib/checksum_wrappers.c:24:
> arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: error: data definition has no type or storage class [-Werror]
> DECLARE_STATIC_KEY_FALSE(uaccess_flush_key);
> ^~~~~~~~~~~~~~~~~~~~~~~~
> arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: error: type defaults to ‘int’ in declaration of ‘DECLARE_STATIC_KEY_FALSE’ [-Werror=implicit-int]
> arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: error: parameter names (without types) in function declaration [-Werror]
> arch/powerpc/include/asm/book3s/64/kup-radix.h: In function ‘prevent_user_access’:
> arch/powerpc/include/asm/book3s/64/kup-radix.h:18:6: error: implicit declaration of function ‘static_branch_unlikely’ [-Werror=implicit-function-declaration]
> if (static_branch_unlikely(&uaccess_flush_key))
> ^~~~~~~~~~~~~~~~~~~~~~
> arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: error: ‘uaccess_flush_key’ undeclared (first use in this function); did you mean ‘do_uaccess_flush’?
> if (static_branch_unlikely(&uaccess_flush_key))
> ^~~~~~~~~~~~~~~~~
> do_uaccess_flush
> arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: note: each undeclared identifier is reported only once for each function it appears in
> cc1: all warnings being treated as errors
> make[2]: *** [arch/powerpc/lib/checksum_wrappers.o] Error 1
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [arch/powerpc/lib] Error 2
> make[1]: *** Waiting for unfinished jobs....
> In file included from arch/powerpc/include/asm/kup.h:10:0,
> from arch/powerpc/include/asm/uaccess.h:12,
> from include/linux/uaccess.h:8,
> from include/linux/crypto.h:26,
> from crypto/cipher.c:17:
> arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: warning: data definition has no type or storage class
> DECLARE_STATIC_KEY_FALSE(uaccess_flush_key);
> ^~~~~~~~~~~~~~~~~~~~~~~~
> arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: error: type defaults to ‘int’ in declaration of ‘DECLARE_STATIC_KEY_FALSE’ [-Werror=implicit-int]
> arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: warning: parameter names (without types) in function declaration
> arch/powerpc/include/asm/book3s/64/kup-radix.h: In function ‘prevent_user_access’:
> arch/powerpc/include/asm/book3s/64/kup-radix.h:18:6: error: implicit declaration of function ‘static_branch_unlikely’ [-Werror=implicit-function-declaration]
> if (static_branch_unlikely(&uaccess_flush_key))
> ^~~~~~~~~~~~~~~~~~~~~~
> arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: error: ‘uaccess_flush_key’ undeclared (first use in this function); did you mean ‘do_uaccess_flush’?
> if (static_branch_unlikely(&uaccess_flush_key))
> ^~~~~~~~~~~~~~~~~
> do_uaccess_flush
> arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: note: each undeclared identifier is reported only once for each function it appears in
> cc1: some warnings being treated as errors
> make[2]: *** [crypto/cipher.o] Error 1
> make[2]: *** Waiting for unfinished jobs....
> In file included from arch/powerpc/include/asm/kup.h:10:0,
> from arch/powerpc/include/asm/uaccess.h:12,
> from include/linux/uaccess.h:8,
> from include/linux/crypto.h:26,
> from crypto/compress.c:15:
> arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: warning: data definition has no type or storage class
> DECLARE_STATIC_KEY_FALSE(uaccess_flush_key);
> ^~~~~~~~~~~~~~~~~~~~~~~~
> arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: error: type defaults to ‘int’ in declaration of ‘DECLARE_STATIC_KEY_FALSE’ [-Werror=implicit-int]
> arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: warning: parameter names (without types) in function declaration
> arch/powerpc/include/asm/book3s/64/kup-radix.h: In function ‘prevent_user_access’:
> arch/powerpc/include/asm/book3s/64/kup-radix.h:18:6: error: implicit declaration of function ‘static_branch_unlikely’ [-Werror=implicit-function-declaration]
> if (static_branch_unlikely(&uaccess_flush_key))
> ^~~~~~~~~~~~~~~~~~~~~~
> arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: error: ‘uaccess_flush_key’ undeclared (first use in this function); did you mean ‘do_uaccess_flush’?
> if (static_branch_unlikely(&uaccess_flush_key))
> ^~~~~~~~~~~~~~~~~
> do_uaccess_flush
> arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: note: each undeclared identifier is reported only once for each function it appears in
> cc1: some warnings being treated as errors
> make[2]: *** [crypto/compress.o] Error 1
> In file included from arch/powerpc/include/asm/kup.h:10:0,
> from arch/powerpc/include/asm/uaccess.h:12,
> from include/linux/uaccess.h:8,
> from include/linux/crypto.h:26,
> from include/crypto/algapi.h:15,
> from crypto/memneq.c:62:
> arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: warning: data definition has no type or storage class
> DECLARE_STATIC_KEY_FALSE(uaccess_flush_key);
> ^~~~~~~~~~~~~~~~~~~~~~~~
> arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: error: type defaults to ‘int’ in declaration of ‘DECLARE_STATIC_KEY_FALSE’ [-Werror=implicit-int]
> arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: warning: parameter names (without types) in function declaration
> arch/powerpc/include/asm/book3s/64/kup-radix.h: In function ‘prevent_user_access’:
> arch/powerpc/include/asm/book3s/64/kup-radix.h:18:6: error: implicit declaration of function ‘static_branch_unlikely’ [-Werror=implicit-function-declaration]
> if (static_branch_unlikely(&uaccess_flush_key))
> ^~~~~~~~~~~~~~~~~~~~~~
> arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: error: ‘uaccess_flush_key’ undeclared (first use in this function); did you mean ‘do_uaccess_flush’?
> if (static_branch_unlikely(&uaccess_flush_key))
> ^~~~~~~~~~~~~~~~~
> do_uaccess_flush
> arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: note: each undeclared identifier is reported only once for each function it appears in
> cc1: some warnings being treated as errors
> make[2]: *** [crypto/memneq.o] Error 1
> make[1]: *** [crypto] Error 2
> In file included from arch/powerpc/include/asm/kup.h:10:0,
> from arch/powerpc/include/asm/uaccess.h:12,
> from include/asm-generic/termios-base.h:7,
> from arch/powerpc/include/asm/termios.h:20,
> from include/uapi/linux/termios.h:5,
> from include/linux/tty.h:6,
> from kernel/signal.c:18:
> arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: warning: data definition has no type or storage class
> DECLARE_STATIC_KEY_FALSE(uaccess_flush_key);
> ^~~~~~~~~~~~~~~~~~~~~~~~
> arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: error: type defaults to ‘int’ in declaration of ‘DECLARE_STATIC_KEY_FALSE’ [-Werror=implicit-int]
> arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: warning: parameter names (without types) in function declaration
> arch/powerpc/include/asm/book3s/64/kup-radix.h: In function ‘prevent_user_access’:
> arch/powerpc/include/asm/book3s/64/kup-radix.h:18:6: error: implicit declaration of function ‘static_branch_unlikely’ [-Werror=implicit-function-declaration]
> if (static_branch_unlikely(&uaccess_flush_key))
> ^~~~~~~~~~~~~~~~~~~~~~
> arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: error: ‘uaccess_flush_key’ undeclared (first use in this function); did you mean ‘do_uaccess_flush’?
> if (static_branch_unlikely(&uaccess_flush_key))
> ^~~~~~~~~~~~~~~~~
> do_uaccess_flush
> arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: note: each undeclared identifier is reported only once for each function it appears in
> In file included from arch/powerpc/include/asm/kup.h:10:0,
> from arch/powerpc/include/asm/uaccess.h:12,
> from include/asm-generic/termios-base.h:7,
> from arch/powerpc/include/asm/termios.h:20,
> from include/uapi/linux/termios.h:5,
> from include/linux/tty.h:6,
> from arch/powerpc/kernel/setup_64.c:27:
> arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: error: data definition has no type or storage class [-Werror]
> DECLARE_STATIC_KEY_FALSE(uaccess_flush_key);
> ^~~~~~~~~~~~~~~~~~~~~~~~
> arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: error: type defaults to ‘int’ in declaration of ‘DECLARE_STATIC_KEY_FALSE’ [-Werror=implicit-int]
> arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: error: parameter names (without types) in function declaration [-Werror]
> arch/powerpc/include/asm/book3s/64/kup-radix.h: In function ‘prevent_user_access’:
> arch/powerpc/include/asm/book3s/64/kup-radix.h:18:6: error: implicit declaration of function ‘static_branch_unlikely’ [-Werror=implicit-function-declaration]
> if (static_branch_unlikely(&uaccess_flush_key))
> ^~~~~~~~~~~~~~~~~~~~~~
> arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: error: ‘uaccess_flush_key’ undeclared (first use in this function); did you mean ‘do_uaccess_flush’?
> if (static_branch_unlikely(&uaccess_flush_key))
> ^~~~~~~~~~~~~~~~~
> do_uaccess_flush
> arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: note: each undeclared identifier is reported only once for each function it appears in
> cc1: some warnings being treated as errors
> make[2]: *** [kernel/signal.o] Error 1
> make[2]: *** Waiting for unfinished jobs....
> cc1: all warnings being treated as errors
> make[2]: *** [arch/powerpc/kernel/setup_64.o] Error 1
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [arch/powerpc/kernel] Error 2
> In file included from arch/powerpc/include/asm/kup.h:10:0,
> from arch/powerpc/include/asm/uaccess.h:12,
> from include/linux/poll.h:11,
> from fs/bad_inode.c:16:
> arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: warning: data definition has no type or storage class
> DECLARE_STATIC_KEY_FALSE(uaccess_flush_key);
> ^~~~~~~~~~~~~~~~~~~~~~~~
> arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: error: type defaults to ‘int’ in declaration of ‘DECLARE_STATIC_KEY_FALSE’ [-Werror=implicit-int]
> arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: warning: parameter names (without types) in function declaration
> arch/powerpc/include/asm/book3s/64/kup-radix.h: In function ‘prevent_user_access’:
> arch/powerpc/include/asm/book3s/64/kup-radix.h:18:6: error: implicit declaration of function ‘static_branch_unlikely’ [-Werror=implicit-function-declaration]
> if (static_branch_unlikely(&uaccess_flush_key))
> ^~~~~~~~~~~~~~~~~~~~~~
> arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: error: ‘uaccess_flush_key’ undeclared (first use in this function); did you mean ‘do_uaccess_flush’?
> if (static_branch_unlikely(&uaccess_flush_key))
> ^~~~~~~~~~~~~~~~~
> do_uaccess_flush
> arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: note: each undeclared identifier is reported only once for each function it appears in
> cc1: some warnings being treated as errors

Daniel, your commit broke this on 4.9, and on 4.14.y. If you could
provide fix-up patches for these trees as well, that would be great.

thanks,

greg k-h

Next message: Christian Eggers: "[PATCH net-next 0/3] net: ptp: use common defines for PTP message types in further drivers"
Previous message: Greg Kroah-Hartman: "Re: [PATCH 4.4 00/15] 4.4.245-rc1 review"
In reply to: Guenter Roeck: "Re: [PATCH 4.9 00/16] 4.9.245-rc1 review"
Next in thread: Naresh Kamboju: "Re: [PATCH 4.9 00/16] 4.9.245-rc1 review"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]