Re: [PATCH 1/3] Input: goodix - add option to disable firmware loading

From: Dmitry Torokhov
Date: Mon Nov 23 2020 - 01:53:46 EST


On Fri, Oct 30, 2020 at 10:56:20AM +0100, Hans de Goede wrote:
> Hi,
>
> On 10/29/20 9:36 PM, Dmitry Torokhov wrote:
> > Hi Andrej,
> >
> > On Thu, Oct 29, 2020 at 06:03:11PM +0100, Andrej Valek wrote:
> >> Firmware file loadind for GT911 controller takes too much time (~60s).
> >> There is no check that configuration is the same which is already present.
> >> This happens always during boot, which makes touchscreen unusable.
> >>
> >> Add there an option to prevent firmware file loading, but keep it enabled
> >> by default.
> >
> > I thought that Goodix was losing firmware loading at poweroff. Is this
> > not the case with this model?
>
> So first of all there are 2 sorts of firmware involved with the
> Goodix touchscreen controllers, the actual firmware and a block
> of config data for that firmware which I presume adjusts it for
> the specific (model of) the digitizer which is attached.
>
> ATM the mainline Linux driver does not support models where
> the actual firmware itself needs to be loaded (because they
> only have RAM, so they come up without firmware).
>
> I do have one model tablet with a ROM-less goodix touchpad
> controller, so if I ever find the time I might add support
> for loading the actual firmware.
>
> So what we are talking about here is just loading the config
> data and I'm a bit surprised that this take so long.

So I am still confused about this: is the config stored in RAM or NVRAM?
I.e. do we actually need to re-load it every time on boot, or it
supposed to be flashed only when it is changed (or lost)?

Thanks.

--
Dmitry