Re: [PATCH v5 0/7] gpio: exar: refactor the driver

From: Bartosz Golaszewski
Date: Mon Nov 23 2020 - 08:07:50 EST


On Mon, Nov 23, 2020 at 1:12 PM Jan Kiszka <jan.kiszka@xxxxxxxxxxx> wrote:
>
> On 23.11.20 12:58, Jan Kiszka wrote:
> > On 23.11.20 12:38, Bartosz Golaszewski wrote:
> >> On Mon, Nov 16, 2020 at 11:42 AM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
> >>>
> >>> From: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
> >>>
> >>> I just wanted to convert the driver to using simpler IDA API but ended up
> >>> quickly converting it to using regmap. Unfortunately I don't have the HW
> >>> to test it so marking the patches that introduce functional change as RFT
> >>> and Cc'ing the original author.
> >>>
> >>
> >> Hi Jan!
> >>
> >> Could you give this last version a final spin before I merge it?
> >>
> >
> > [ 14.250117] exar_serial 0000:02:00.0: enabling device (0000 -> 0002)
> > [ 14.336622] 0000:02:00.0: ttyS2 at MMIO 0x90000000 (irq = 44, base_baud = 7812500) is a XR17V35X
> > [ 14.391588] 0000:02:00.0: ttyS3 at MMIO 0x90000400 (irq = 44, base_baud = 7812500) is a XR17V35X
> > [ 19.250510] gpio_exar: probe of gpio_exar.1.auto failed with error -22
> >
> > That's "new"...
> >
>
> Bisected to "gpio: exar: switch to using regmap" again.
>

I'm not sure if you saw my email which I sent at the same time as you
- but does reverting reg_bits to 16 help?

Bart