Re: [PATCH net-next v4 2/5] net/lapb: support netdev events

[Martin Schiller]

On 2020-11-23 23:09, Xie He wrote:
> On Mon, Nov 23, 2020 at 11:36 AM Jakub Kicinski <kuba@xxxxxxxxxx> 
> wrote:
> > > >  From this point of view it will be the best to handle the NETDEV_UP in
> > > > the lapb event handler and establish the link analog to the
> > > > NETDEV_CHANGE event if the carrier is UP.
> > >
> > > Thanks! This way we can make sure LAPB would automatically connect in
> > > all situations.
> > >
> > > Since we'll have a netif_carrier_ok check in NETDEV_UP handing, it
> > > might make the code look prettier to also have a netif_carrier_ok
> > > check in NETDEV_GOING_DOWN handing (for symmetry). Just a suggestion.
> > > You can do whatever looks good to you :)
> >
> > Xie other than this the patches look good to you?
> >
> > Martin should I expect a respin to follow Xie's suggestion
> > or should I apply v4?
>
> There should be a respin because we need to handle the NETDEV_UP
> event. The lapbether driver (and possibly some HDLC WAN drivers)
> doesn't generate carrier events so we need to do auto-connect in the
> NETDEV_UP event.

I'll send a v5 with the appropriate change.