Re: [PATCH 1/3] irqchip: qcom-pdc: Fix phantom irq when changing between rising/falling

[Maulik Shah]

Hi Linus,

+	 * When we change types the PDC can give a phantom interrupt.
+	 * Clear it.  Specifically the phantom shows up if a line is already
+	 * high and we change to rising or if a line is already low and we
+	 * change to falling but let's be consistent and clear it always.
+	 *

Can you please hold this change. I am checking with HW folks if above 
commented behaviour is expected/is valid case to set the irq type rising 
edge when the line is already high.

Will keep posting update here.

Thanks,
Maulik

On 11/24/2020 10:25 PM, Doug Anderson wrote:
> Hi,
>
> On Tue, Nov 24, 2020 at 12:28 AM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> > On Tue, Nov 24, 2020 at 1:02 AM Douglas Anderson <dianders@xxxxxxxxxxxx> wrote:
> >
> > > We have a problem if we use gpio-keys and configure wakeups such that
> > > we only want one edge to wake us up.  AKA:
> > >    wakeup-event-action = <EV_ACT_DEASSERTED>;
> > >    wakeup-source;
> > I would need Marc's ACK to apply this with the other patches
> > to the pinctrl tree, but I can't really see if maybe it is OK to
> > apply it separately?
> I'll make an explicit note after the cut in the patch, but to also
> respond here: we can apply this patch on its own.  The only reason I
> sent as one series is because they address similar issues, this patch
> stands on its own.  Patch #3 needs #2 but patch #2/#3 don't need patch
> #1.
>
> > Also are these patches supposed to all go in as fixes or
> > for v5.11?
> Wherever it makes sense.
>
> -Doug

--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation