Re: [PATCH][next] drm/mcde: fix masking and bitwise-or on variable val

[Linus Walleij]

On Tue, Nov 24, 2020 at 1:15 PM Colin King <colin.king@xxxxxxxxxxxxx> wrote:

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> The masking of val with ~MCDE_CRX1_CLKSEL_MASK is currently being
> ignored because there seems to be a missing bitwise-or of val in the
> following statement.  Fix this by replacing the assignment of val
> with a bitwise-or.
>
> Addresses-Coverity: ("Unused valued")
> Fixes: d795fd322063 ("drm/mcde: Support DPI output")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Nice catch!
Patch applied.

Yours,
Linus Walleij