Re: [PATCH 8/9] ARM: mstar: Add smp ctrl registers to infinity2m dtsi

[Daniel Palmer]

Hi Arnd,

On Mon, 30 Nov 2020 at 22:44, Arnd Bergmann <arnd@xxxxxxxxxx> wrote:
>
> On Mon, Nov 30, 2020 at 2:10 PM Daniel Palmer <daniel@xxxxxxxx> wrote:
> >
> > +&riu {
> > +       smpctrl@204000 {
> > +               compatible = "mstar,smpctrl";
> > +               reg = <0x204000 0x200>;
> > +               status = "okay";
> > +       };
>
> You probably want some more specific compatible value, in case there are
> multiple SoCs from mstar that have an smpctrl block and they don't all use
> an exactly identical register layout.
>

>From what I can tell these are in the same place for the infinity2m and
the other SMP chip in this series that are in the infinity6 series.

Would "mstar,i2m-smpctrl" make more sense?

Thanks,

Daniel