Re: [PATCH] sched/fair: Clear SMT siblings after determining the core is not idle

From: Peter Zijlstra
Date: Tue Dec 01 2020 - 06:04:30 EST


On Mon, Nov 30, 2020 at 03:47:01PM +0100, Vincent Guittot wrote:
> On Mon, 30 Nov 2020 at 15:40, Mel Gorman <mgorman@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > The clearing of SMT siblings from the SIS mask before checking for an idle
> > core is a small but unnecessary cost. Defer the clearing of the siblings
> > until the scan moves to the next potential target. The cost of this was
> > not measured as it is borderline noise but it should be self-evident.
>
> Good point
>
> >
> > Signed-off-by: Mel Gorman <mgorman@xxxxxxxxxxxxxxxxxxx>
>
> Reviewed-by: Vincent Guittot <vincent.guittot@xxxxxxxxxx>

Thanks!