Re: [BUG] SPI broken for SPI based panel drivers

From: H. Nikolaus Schaller
Date: Tue Dec 01 2020 - 09:38:58 EST


Hi Linus,

> Am 01.12.2020 um 15:20 schrieb Linus Walleij <linus.walleij@xxxxxxxxxx>:
>
> Hi Nikolaus, Sven,
>
> the fault that the thing broke in the first place is all mine.
> Credit where credit is due!
>
> The reason why I shoot in the dark to convert all SPI
> drivers to use GPIO descriptors instead of the global
> GPIO numberspace is detailed in drivers/gpio/TODO
> so I will not repeat it here.
>
> I don't know if much can be done about it other than
> having better programmers than me at the task. Or
> less tired when they write the patch. etc.
>
> What other operating systems do to get around the same
> type of refactoring problem is to aggressively
> deprecate and delete code that does not follow the
> latest ideas of the driver subsystem developer. This
> is not an option on Linux because we don't like to leave
> working hardware and users behind so I am painstakingly
> fixing it all over the place, with a little help from my
> friends. Sometimes it blows up in my face, sometimes
> in other people faces too, sorry about that.

Everyone has such a patch written at the wrong time of the day...
See for example: f069b5a0b27a

Let's work on a fix for the fix now.

BR and thanks,
Nikolaus