RE: [PATCH v3] PCI: cadence: Retrain Link to work around Gen2 training defect.

From: Athani Nadeem Ladkhan
Date: Tue Dec 01 2020 - 10:16:57 EST


Hi Kishon,

> -----Original Message-----
> From: Kishon Vijay Abraham I <kishon@xxxxxx>
> Sent: Thursday, November 26, 2020 7:28 PM
> To: Rob Herring <robh@xxxxxxxxxx>
> Cc: Athani Nadeem Ladkhan <nadeem@xxxxxxxxxxx>;
> lorenzo.pieralisi@xxxxxxx; bhelgaas@xxxxxxxxxx; linux-
> pci@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Tom Joseph
> <tjoseph@xxxxxxxxxxx>; Swapnil Kashinath Jakhade
> <sjakhade@xxxxxxxxxxx>; Milind Parab <mparab@xxxxxxxxxxx>
> Subject: Re: [PATCH v3] PCI: cadence: Retrain Link to work around Gen2
> training defect.
>
> EXTERNAL MAIL
>
>
> Hi Tom, Nadeem,
>
> On 27/10/20 12:50 am, Rob Herring wrote:
> > On Fri, Oct 23, 2020 at 1:57 AM Kishon Vijay Abraham I <kishon@xxxxxx>
> wrote:
> >>
> >> Hi Nadeem,
> >>
> >> On 19/10/20 10:48 pm, Athani Nadeem Ladkhan wrote:
> >>> Hi Kishon,
> >>>
> >>>> -----Original Message-----
> >>>> From: Kishon Vijay Abraham I <kishon@xxxxxx>
> >>>> Sent: Monday, October 19, 2020 10:59 AM
> >>>> To: Athani Nadeem Ladkhan <nadeem@xxxxxxxxxxx>;
> >>>> lorenzo.pieralisi@xxxxxxx; robh@xxxxxxxxxx; bhelgaas@xxxxxxxxxx;
> >>>> linux- pci@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Tom
> >>>> Joseph <tjoseph@xxxxxxxxxxx>
> >>>> Cc: Swapnil Kashinath Jakhade <sjakhade@xxxxxxxxxxx>; Milind Parab
> >>>> <mparab@xxxxxxxxxxx>
> >>>> Subject: Re: [PATCH v3] PCI: cadence: Retrain Link to work around
> >>>> Gen2 training defect.
> >>>>
> >>>> EXTERNAL MAIL
> >>>>
> >>>>
> >>>> Hi Nadeem,
> >>>>
> >>>> On 30/09/20 11:51 pm, Nadeem Athani wrote:
> >>>>> Cadence controller will not initiate autonomous speed change if
> >>>>> strapped as Gen2. The Retrain Link bit is set as quirk to enable
> >>>>> this speed
> >>>> change.
> >>>>>
> >>>>> Signed-off-by: Nadeem Athani <nadeem@xxxxxxxxxxx>
>
> Do you have a follow-up patch fixing the review comments?
We planned to fix this in coming 3 weeks.
>
> Thanks
> Kishon