Re: [PATCH v9 3/8] ima: Define get_ima_kexec_buffer() in drivers/of

[Lakshmi Ramasubramanian]

On 12/1/20 3:37 AM, Mimi Zohar wrote:
> On Fri, 2020-11-13 at 11:22 -0800, Lakshmi Ramasubramanian wrote:
> > The function do_get_kexec_buffer(), defined in arch/powerpc/kexec/ima.c,
> > retrieves the address and size of the given property from the device
> > tree blob. This function does not have architecture specific code, but is
> > currently limited to powerpc. This function correctly handles a device
> > tree property that is a child node of the root node, but not anything
> > other than the immediate root child nodes.
> >
> > Define an architecture independent function, namely
> > get_ima_kexec_buffer(), in "drivers/of/ima_kexec.c". This function
> > retrieves the chosen node, namely "linux,ima-kexec-buffer", from
>
> Please remove the word "namely", here, and throughout the patch sets.
>
> > the device tree, and returns the address and size of the buffer used
> > for carrying forward the IMA measurement log across kexec system call.
>
> get_ima_kexec_buffer() inlines the existing do_get_kexec_buffer() and
> get_addr_size_cells() functions, leaving a local copy of
> get_addr_size_cells().   Duplicating code isn't a good idea.

I'll move get_addr_size_cells() also to drivers/of/ima_kexec.c

thanks,
 -lakshmi