Re: [V9fs-developer] [PATCH] fs: 9p: add generic splice_read file operations

From: Toke Høiland-Jørgensen
Date: Tue Dec 01 2020 - 15:38:47 EST


Dominique Martinet <asmadeus@xxxxxxxxxxxxx> writes:

> Toke Høiland-Jørgensen wrote on Tue, Dec 01, 2020:
>> > This made me test copy_file_range, and it works with both as well (used
>> > not to)
>> >
>> > interestingly on older kernels this came as default somehow? I have
>> > splice working on 5.4.67 :/ so this broke somewhat recently...
>>
>> Huh, no idea; this is my first time digging into filesystem code, I
>> normally do networking and BPF :)
>
> In case anyone else wants to know, this broke in 5.10-rc1 with
> 36e2c7421f02 ("fs: don't allow splice read/write without explicit ops")
>
> So really a recent regression, good catch :)

Thanks - and what a lucky coincidence that I happened upon this now so
it can be fixed before 5.10-final :)

-Toke