Re: [PATCH v4 4/4] powercap/drivers/dtpm: Add CPU energy model based support

[Lukasz Luba]

On 12/1/20 7:28 PM, Daniel Lezcano wrote:
> With the powercap dtpm controller, we are able to plug devices with
> power limitation features in the tree.
>
> The following patch introduces the CPU power limitation based on the
> energy model and the performance states.
>
> The power limitation is done at the performance domain level. If some
> CPUs are unplugged, the corresponding power will be subtracted from
> the performance domain total power.
>
> It is up to the platform to initialize the dtpm tree and add the CPU.
>
> Here is an example to create a simple tree with one root node called
> "pkg" and the CPU's performance domains.
>
> static int dtpm_register_pkg(struct dtpm_descr *descr)
> {
> 	struct dtpm *pkg;
> 	int ret;
>
> 	pkg = dtpm_alloc(NULL);
> 	if (!pkg)
> 		return -ENOMEM;
>
> 	ret = dtpm_register(descr->name, pkg, descr->parent);
> 	if (ret)
> 		return ret;
>
> 	return dtpm_register_cpu(pkg);
> }
>
> static struct dtpm_descr descr = {
> 	.name = "pkg",
> 	.init = dtpm_register_pkg,
> };
> DTPM_DECLARE(descr);
>
> Cc: Thara Gopinath <thara.gopinath@xxxxxxxxxx>
> Cc: Lina Iyer <ilina@xxxxxxxxxxxxxx>
> Cc: Ram Chandrasekar <rkumbako@xxxxxxxxxxxxxx>
> Cc: Zhang Rui <rui.zhang@xxxxxxxxx>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>


LGTM

Reviewed-by: Lukasz Luba <lukasz.luba@xxxxxxx>
Tested-by: Lukasz Luba <lukasz.luba@xxxxxxx>

Regards,
Lukasz