Re: [PATCH v2 2/4] kunit: tool: stop using bare asserts in unit test

[David Gow]

On Thu, Dec 3, 2020 at 3:09 AM Daniel Latypov <dlatypov@xxxxxxxxxx> wrote:
>
> Use self.assertEqual/assertNotEqual() instead.
> Besides being more appropriate in a unit test, it'll also give a better
> error message by show the unexpected values.
>
> Also
> * Delete redundant check of exception types. self.assertRaises does this.
> * s/kall/call. There's no reason to name it this way.
>   * This is probably a misunderstanding from the docs which uses it
>   since `mock.call` is in scope as `call`.
>
> Signed-off-by: Daniel Latypov <dlatypov@xxxxxxxxxx>
> ---

Looks good, thanks!

Reviewed-by: David Gow <davidgow@xxxxxxxxxx>


-- David