Re: [PATCH v3 4/4] arm: dts: visconti: Add DT support for Toshiba Visconti5 GPIO driver

[Punit Agrawal]

Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@xxxxxxxxxxxxx> writes:

> Add the GPIO node in Toshiba Visconti5 SoC-specific DT file.
> And enable the GPIO node in TMPV7708 RM main board's board-specific DT file.
>
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@xxxxxxxxxxxxx>
> ---
>  .../boot/dts/toshiba/tmpv7708-rm-mbrc.dts     |  4 +++
>  arch/arm64/boot/dts/toshiba/tmpv7708.dtsi     | 27 +++++++++++++++++++
>  2 files changed, 31 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/toshiba/tmpv7708-rm-mbrc.dts b/arch/arm64/boot/dts/toshiba/tmpv7708-rm-mbrc.dts
> index ed0bf7f13f54..950010a290f0 100644
> --- a/arch/arm64/boot/dts/toshiba/tmpv7708-rm-mbrc.dts
> +++ b/arch/arm64/boot/dts/toshiba/tmpv7708-rm-mbrc.dts
> @@ -41,3 +41,7 @@ &uart1 {
>  	clocks = <&uart_clk>;
>  	clock-names = "apb_pclk";
>  };
> +
> +&gpio {
> +	status = "okay";
> +};
> diff --git a/arch/arm64/boot/dts/toshiba/tmpv7708.dtsi b/arch/arm64/boot/dts/toshiba/tmpv7708.dtsi
> index 242f25f4e12a..ac9bddb35b0a 100644
> --- a/arch/arm64/boot/dts/toshiba/tmpv7708.dtsi
> +++ b/arch/arm64/boot/dts/toshiba/tmpv7708.dtsi
> @@ -157,6 +157,33 @@ pmux: pmux@24190000 {
>  			reg = <0 0x24190000 0 0x10000>;
>  		};
>  
> +		gpio: gpio@28020000 {
> +			compatible = "toshiba,gpio-tmpv7708";
> +			reg = <0 0x28020000 0 0x1000>;
> +			#gpio-cells = <0x2>;
> +			gpio-ranges = <&pmux 0 0 32>;
> +			gpio-controller;
> +			interrupt-controller;
> +			#interrupt-cells = <2>;
> +			interrupts =
> +				<GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 27 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 34 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 38 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>;
> +		};
> +
>  		uart0: serial@28200000 {
>  			compatible = "arm,pl011", "arm,primecell";
>  			reg = <0 0x28200000 0 0x1000>;

FWIW,

Reviewed-by: Punit Agrawal <punit1.agrawal@xxxxxxxxxxxxx>

Thanks,
Punit