Re: [PATCH net-next v5 9/9] net: dsa: microchip: ksz9477: add periodic output support

From: Vladimir Oltean
Date: Thu Dec 03 2020 - 20:01:40 EST


On Thu, Dec 03, 2020 at 04:45:56PM -0800, Richard Cochran wrote:
> On Thu, Dec 03, 2020 at 04:36:26PM +0100, Christian Eggers wrote:
> > Should ptp_sysfs be extended with a "pulse" attribute with calls
> > enable() with only PTP_PEROUT_DUTY_CYCLE set?
>
> Yes, that would make sense. It would bring sysfs back to feature
> parity with the ioctls.

Which is a good thing?

Anyway, Christian, if you do decide to do that, here's some context why
I didn't do it when I added the additional knobs for periodic output:
https://www.mail-archive.com/linuxptp-devel@xxxxxxxxxxxxxxxxxxxxx/msg04150.html