Re: [PATCH 2/2] platform/chrome: cros_ec_spi: Drop bits_per_word assignment

From: Enric Balletbo i Serra
Date: Fri Dec 04 2020 - 04:16:34 EST


Hi Stephen,

Thank you for your patch.

On 3/12/20 2:16, Stephen Boyd wrote:
> This is already handed by default in spi_setup() if the bits_per_word is
> 0, so just drop it to shave off a line.
>
> Cc: Simon Glass <sjg@xxxxxxxxxxxx>
> Cc: Gwendal Grignou <gwendal@xxxxxxxxxxxx>
> Cc: Douglas Anderson <dianders@xxxxxxxxxxxx>
> Cc: Alexandru M Stan <amstan@xxxxxxxxxxxx>
> Signed-off-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>

Acked-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx>

> ---
> drivers/platform/chrome/cros_ec_spi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_spi.c b/drivers/platform/chrome/cros_ec_spi.c
> index f9df218fc2bb..14c4046fa04d 100644
> --- a/drivers/platform/chrome/cros_ec_spi.c
> +++ b/drivers/platform/chrome/cros_ec_spi.c
> @@ -741,7 +741,6 @@ static int cros_ec_spi_probe(struct spi_device *spi)
> struct cros_ec_spi *ec_spi;
> int err;
>
> - spi->bits_per_word = 8;
> spi->rt = true;
> err = spi_setup(spi);
> if (err < 0)
>