Re: [PATCH v2 0/4] Venus encoder improvements
From: Fritz Koenig
Date: Fri Dec 04 2020 - 21:45:12 EST
On Fri, Dec 4, 2020 at 2:03 AM Stanimir Varbanov
<stanimir.varbanov@xxxxxxxxxx> wrote:
>
> Hello,
>
> Changes since v1:
> * 1/4 - fixed error handling in hfi_session_deinit (Alex)
> - keep venc_set_properties invocation from start_streaming (Dikshita)
> * 2/4 - keep original mutex_lock (Alex)
> * 3/4 - move msg queue inside if statement (Fritz)
> - move rx_req setting before triggering soft interrupt (Alex)
> * Add one more patch 4/4 to address comments for hfi_session_init
> EINVAL return error code (Alex)
>
> The v1 can be found at [1].
>
> regards,
> Stan
>
> [1] https://www.spinics.net/lists/linux-media/msg181634.html
>
> Stanimir Varbanov (3):
> venus: venc: Init the session only once in queue_setup
> venus: Limit HFI sessions to the maximum supported
> venus: hfi: Correct session init return error
>
> Vikash Garodia (1):
> media: venus: request for interrupt from venus
>
> drivers/media/platform/qcom/venus/core.h | 1 +
> drivers/media/platform/qcom/venus/hfi.c | 18 +++-
> .../media/platform/qcom/venus/hfi_parser.c | 3 +
> drivers/media/platform/qcom/venus/hfi_venus.c | 77 ++++++++++-------
> drivers/media/platform/qcom/venus/vdec.c | 2 +-
> drivers/media/platform/qcom/venus/venc.c | 85 ++++++++++++++-----
> 6 files changed, 127 insertions(+), 59 deletions(-)
>
> --
> 2.17.1
>
I haven't had a chance to review the code yet, I'll leave that for
early next week. In the meantime I have tested the patches and found
them to be working well.
Tested-by: Fritz Koenig <frkoenig@xxxxxxxxxxxx>