Re: [PATCH 3/3] Serial: Separate out earlycon support

From: Greg KH
Date: Mon Dec 07 2020 - 04:11:16 EST


On Mon, Dec 07, 2020 at 02:17:27PM +0530, Akash Asthana wrote:
> Separate out earlycon support from serial driver and remove it's
> dependency on QUP wrapper driver.
>
> This enable us to manage earlycon independently and we can re-use the
> same earlycon driver for android project which currently uses
> downstream version of QUP drivers.

What do you mean by "downstream" here?

>
> Signed-off-by: Akash Asthana <akashast@xxxxxxxxxxxxxx>
> ---
> drivers/tty/serial/Kconfig | 9 +
> drivers/tty/serial/Makefile | 1 +
> drivers/tty/serial/qcom_geni_earlycon.c | 649 ++++++++++++++++++++++++++++++++
> drivers/tty/serial/qcom_geni_serial.c | 97 -----

So you are replacing 97 lines of code with 649 lines? How is this
benefiting anyone?

confused,

greg k-h