Re: [PATCH] rseq/selftests: Fix MEMBARRIER_CMD_PRIVATE_EXPEDITED_RSEQ build error under other arch.

[Shuah Khan]

On 11/25/20 9:10 AM, Mathieu Desnoyers wrote:
> ----- On Nov 24, 2020, at 11:04 PM, Xingxing Su suxingxing@xxxxxxxxxxx wrote:
>
> > Except arch x86, the function rseq_offset_deref_addv is not defined.
> > The function test_membarrier_manager_thread call rseq_offset_deref_addv
> > produces a build error.
> >
> > The RSEQ_ARCH_HAS_OFFSET_DEREF_ADD should contain all the code
> > for the MEMBARRIER_CMD_PRIVATE_EXPEDITED_RSEQ.
> > If the other Arch implements this feature,
> > defined RSEQ_ARCH_HAS_OFFSET_DEREF_ADD in the header file
> > to ensure that this feature is available.
> >
> > Following build errors:
> >
> > param_test.c: In function ‘test_membarrier_worker_thread’:
> > param_test.c:1164:10: warning: implicit declaration of function
> > ‘rseq_offset_deref_addv’
> >     ret = rseq_offset_deref_addv(&args->percpu_list_ptr,
> >           ^~~~~~~~~~~~~~~~~~~~~~
> > /tmp/ccMj9yHJ.o: In function `test_membarrier_worker_thread':
> > param_test.c:1164: undefined reference to `rseq_offset_deref_addv'
> > param_test.c:1164: undefined reference to `rseq_offset_deref_addv'
> > collect2: error: ld returned 1 exit status
> > make: *** [/selftests/rseq/param_test_benchmark] Error 1
> >
> > Signed-off-by: Xingxing Su <suxingxing@xxxxxxxxxxx>
>
> Acked-by: Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx>
>
> Shuah, can you pick up this fix please ?

Applying for 5.11-rc1.

thanks,
-- Shuah