RE: [PATCH v2 3/4] soc: samsung: exynos-chipid: order list of SoCs by name

[Pankaj Dubey]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Sent: Tuesday, December 8, 2020 12:35 AM
> To: Krzysztof Kozlowski <krzk@xxxxxxxxxx>; linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx; linux-samsung-soc@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Cc: Sylwester Nawrocki <snawrocki@xxxxxxxxxx>; Marek Szyprowski
> <m.szyprowski@xxxxxxxxxxx>; Bartlomiej Zolnierkiewicz
> <b.zolnierkie@xxxxxxxxxxx>; Arnd Bergmann <arnd@xxxxxxxx>; Chanwoo
> Choi <cw00.choi@xxxxxxxxxxx>; Alim Akhtar <alim.akhtar@xxxxxxxxxxx>;
> Pankaj Dubey <pankaj.dubey@xxxxxxxxxxx>
> Subject: [PATCH v2 3/4] soc: samsung: exynos-chipid: order list of SoCs by
> name
> 
> Bring some order to the list of SoCs.  No functional change.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> ---
>  drivers/soc/samsung/exynos-chipid.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/samsung/exynos-chipid.c
> b/drivers/soc/samsung/exynos-chipid.c
> index 8d4d05086906..b4cd0cc00f45 100644
> --- a/drivers/soc/samsung/exynos-chipid.c
> +++ b/drivers/soc/samsung/exynos-chipid.c
> @@ -20,6 +20,7 @@ static const struct exynos_soc_id {
>  	const char *name;
>  	unsigned int id;
>  } soc_ids[] = {
> +	/* List ordered by SoC name */
>  	{ "EXYNOS3250", 0xE3472000 },
>  	{ "EXYNOS4210", 0x43200000 },	/* EVT0 revision */
>  	{ "EXYNOS4210", 0x43210000 },
> @@ -29,10 +30,10 @@ static const struct exynos_soc_id {
>  	{ "EXYNOS5260", 0xE5260000 },
>  	{ "EXYNOS5410", 0xE5410000 },
>  	{ "EXYNOS5420", 0xE5420000 },
> +	{ "EXYNOS5433", 0xE5433000 },
>  	{ "EXYNOS5440", 0xE5440000 },
>  	{ "EXYNOS5800", 0xE5422000 },
>  	{ "EXYNOS7420", 0xE7420000 },
> -	{ "EXYNOS5433", 0xE5433000 },
>  };
> 
>  static const char * __init product_id_to_soc_id(unsigned int product_id)
> --
> 2.25.1

Reviewed-by: Pankaj Dubey <pankaj.dubey@xxxxxxxxxxx>