RE: [PATCH] perf arm pmu: fix build error on MUSL libc
From: Chanho Park
Date: Tue Dec 08 2020 - 04:55:48 EST
Hi Namhyung and Jiri,
> -----Original Message-----
> From: Jiri Olsa <jolsa@xxxxxxxxxx>
> Sent: Monday, December 7, 2020 10:29 PM
> To: Namhyung Kim <namhyung@xxxxxxxxxx>
> Cc: Chanho Park <chanho61.park@xxxxxxxxxxx>; Will Deacon
<will@xxxxxxxxxx>;
> Chanho Park <parkch98@xxxxxxxxx>; mathieu.poirier@xxxxxxxxxx;
> suzuki.poulose@xxxxxxx; coresight@xxxxxxxxxxxxxxxx; linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel <linux-kernel@xxxxxxxxxxxxxxx>;
> Mike Leach <mike.leach@xxxxxxxxxx>; Leo Yan <leo.yan@xxxxxxxxxx>; John
> Garry <john.garry@xxxxxxxxxx>; Peter Zijlstra <peterz@xxxxxxxxxxxxx>; Ingo
> Molnar <mingo@xxxxxxxxxx>; Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>;
> Mark Rutland <mark.rutland@xxxxxxx>; Khem Raj <raj.khem@xxxxxxxxx>
> Subject: Re: [PATCH] perf arm pmu: fix build error on MUSL libc
>
> On Mon, Dec 07, 2020 at 09:31:06PM +0900, Namhyung Kim wrote:
> > Hi Chanho,
> >
> > On Mon, Dec 7, 2020 at 8:58 PM Chanho Park <chanho61.park@xxxxxxxxxxx>
> wrote:
> > >
> > > Hi Will,
> > >
> > > > Looks like other files just include this unconditionally, but have
> > > > a comment explaining why. See util/branch.h and util/event.h.
> > > > Maybe we should do the same for util/pmu.h, which is already
> included here?
> > >
> > > I found below files which perf includes <linux/perf_event.h>.
> > > Instead of doing same for all, we'd better put this only for
> > > tools/include/uapi/linux/perf_event.h.
> >
> > It's a copy of the kernel header, I'm not sure we want to add something
> there.
>
> right, we want to copy that directly from kernel uapi so let's not do any
> changes in here
>
I tried to modify it from include/uapi/linux/perf_event.h but it didn't
work. And then, I found perf tool tried to refer the header from
tools/include/ directory. I should go include/uapi first and sync the change
to tools/ directory. I'll re-spin this patch.
Best Regard,
Chanho Park