Re: [PATCH] ceph: remove redundant assignment to variable i
From: Jeff Layton
Date: Tue Dec 08 2020 - 07:34:57 EST
On Fri, 2020-12-04 at 18:54 +0000, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> The variable i is being initialized with a value that is never read
> and it is being updated later with a new value in a for-loop. The
> initialization is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> ---
> fs/ceph/mds_client.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c
> index 8f1d7500a7ec..b70937caa7a7 100644
> --- a/fs/ceph/mds_client.c
> +++ b/fs/ceph/mds_client.c
> @@ -1243,7 +1243,7 @@ static struct ceph_msg *create_session_open_msg(struct ceph_mds_client *mdsc, u6
> {
> struct ceph_msg *msg;
> struct ceph_mds_session_head *h;
> - int i = -1;
> + int i;
> int extra_bytes = 0;
> int metadata_key_count = 0;
> struct ceph_options *opt = mdsc->fsc->client->options;
Meh, ok. Merged into ceph-client/testing branch. It should make v5.11.
Thanks,
--
Jeff Layton <jlayton@xxxxxxxxxx>