Re: [PATCH -next] net/mlx5_core: remove unused including <generated/utsrelease.h>

[Jakub Kicinski]

On Mon, 7 Dec 2020 20:14:00 +0800 Zou Wei wrote:
> Remove including <generated/utsrelease.h> that don't need it.
> 
> Signed-off-by: Zou Wei <zou_wei@xxxxxxxxxx>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
> index 989c70c..82ecc161 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
> @@ -30,7 +30,6 @@
>   * SOFTWARE.
>   */
>  
> -#include <generated/utsrelease.h>
>  #include <linux/mlx5/fs.h>
>  #include <net/switchdev.h>
>  #include <net/pkt_cls.h>


drivers/net/ethernet/mellanox/mlx5/core/en_rep.c: In function ‘mlx5e_rep_get_drvinfo’:
drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:66:28: error: ‘UTS_RELEASE’ undeclared (first use in this function); did you mean ‘CSS_RELEASED’?
   66 |  strlcpy(drvinfo->version, UTS_RELEASE, sizeof(drvinfo->version));
      |                            ^~~~~~~~~~~
      |                            CSS_RELEASED
drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:66:28: note: each undeclared identifier is reported only once for each function it appears in
make[6]: *** [drivers/net/ethernet/mellanox/mlx5/core/en_rep.o] Error 1
make[5]: *** [drivers/net/ethernet/mellanox/mlx5/core] Error 2
make[4]: *** [drivers/net/ethernet/mellanox] Error 2
make[3]: *** [drivers/net/ethernet] Error 2
make[2]: *** [drivers/net] Error 2
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [drivers] Error 2
make: *** [__sub-make] Error 2