Re: [PATCH] x86/apic: Fix CPU devicetree-node lookups

[Thomas Gleixner]

On Tue, Dec 08 2020 at 11:05, Johan Hovold wrote:

> On Tue, Nov 24, 2020 at 02:42:47PM +0100, Johan Hovold wrote:
>> Fix CPU devicetree-node lookups by implementing
>> arch_match_cpu_phys_id().
>> 
>> This allows using of_get_cpu_node() and of_cpu_device_node_get() to look
>> up CPU devicetree nodes and specifically makes sure that CPU struct
>> devices are linked to the correct devicetree nodes.
>> 
>> Note that CPUs are described in devicetree using their APIC ids and
>> that those do not generally coincide with the logical ids (e.g. used by
>> the default arch_match_cpu_phys_id() implementation).

Can you please explain why this is relevant for any of the existing few
x86 DT users?

The above is incoherent word salad TBH:

    1) Fix .....

       without any information what is broken

    2) This allows ...

       It allows. Cool. Is it mandatory, desired or whatever?

    3) Note ...

       That might be an actual problem decsription, but I can't say for
       sure.

Changelog structure should be:

   Set context if necessary

   Describe the problem and the possible impact

   Describe the solution

and not:

    Claim to fix something unspecified

    Give some explanation how cool it is

    Add random notes what might or might not be solved by that.

I still have no idea what this 'Fix' is fixing if it is fixing anything
at all. Is is a fix which needs to be backported or is it a 'fix' which
fixes something which got changed elsewhere and forgotten.

Sorry, my crystalball got lost.

Thanks,

        tglx