Re: [PATCH] drm/sched: Add missing structure comment

From: Luben Tuikov
Date: Wed Dec 09 2020 - 17:30:16 EST


On 2020-12-09 5:24 p.m., Stephen Rothwell wrote:
> Hi Luben,
>
> On Wed, 9 Dec 2020 16:58:07 -0500 Luben Tuikov <luben.tuikov@xxxxxxx> wrote:
>>
>> Add a missing structure comment for the recently
>> added @list member.
>>
>> Signed-off-by: Luben Tuikov <luben.tuikov@xxxxxxx>
>>
>> Cc: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
>> Cc: Daniel Vetter <daniel.vetter@xxxxxxxx>
>> Cc: Christian König <christian.koenig@xxxxxxx>
>
> The commit message tags should all be together at the end of the commit
> message (probably with your SoB last). Also:
>
> Fixes: 8935ff00e3b1 ("drm/scheduler: "node" --> "list"")
> Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>

Right! I was just looking into this as the empty
line up there didn't look good.

I'll resubmit.

Regards,
Luben