RE: [PATCH] block: blk-iocost: fix build for ARCH with missing local64.h files

[Tan, Ley Foon]

> -----Original Message-----
> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Sent: Thursday, December 10, 2020 4:47 AM
> To: linux-kernel@xxxxxxxxxxxxxxx
> Cc: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>; Tejun Heo <tj@xxxxxxxxxx>;
> Jens Axboe <axboe@xxxxxxxxx>; linux-block@xxxxxxxxxxxxxxx; Tan, Ley Foon
> <ley.foon.tan@xxxxxxxxx>; Mark Salter <msalter@xxxxxxxxxx>; Aurelien
> Jacquiot <jacquiot.aurelien@xxxxxxxxx>; linux-c6x-dev@xxxxxxxxxxxxx
> Subject: [PATCH] block: blk-iocost: fix build for ARCH with missing local64.h
> files
> 
> When building block/blk-iocost.c on arch/x6x/ or arch/nios2/, the build fails
> due to missing the <asm/local64.h> file.
> 
> Fix this by adding local64.h as a "generic-y" file in their respective Kbuild files,
> so that they will use a copy of <asm-generic/local64.h> instead (copied to
> arch/*/include/generated/local64.h by the build system).
> 
> c6x or nios2 build error:
> ../block/blk-iocost.c:183:10: fatal error: asm/local64.h: No such file or
> directory
>   183 | #include <asm/local64.h>
> 
> Fixes: 5e124f74325d ("blk-iocost: use local[64]_t for percpu stat")
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: Tejun Heo <tj@xxxxxxxxxx>
> Cc: Jens Axboe <axboe@xxxxxxxxx>
> Cc: linux-block@xxxxxxxxxxxxxxx
> Cc: Ley Foon Tan <ley.foon.tan@xxxxxxxxx>
> Cc: Mark Salter <msalter@xxxxxxxxxx>
> Cc: Aurelien Jacquiot <jacquiot.aurelien@xxxxxxxxx>
> Cc: linux-c6x-dev@xxxxxxxxxxxxx
> ---
>  arch/c6x/include/asm/Kbuild   |    1 +
>  arch/nios2/include/asm/Kbuild |    1 +
>  2 files changed, 2 insertions(+)
> 
> --- linux-next-20201208.orig/arch/c6x/include/asm/Kbuild
> +++ linux-next-20201208/arch/c6x/include/asm/Kbuild
> @@ -1,5 +1,6 @@
>  # SPDX-License-Identifier: GPL-2.0
>  generic-y += extable.h
>  generic-y += kvm_para.h
> +generic-y += local64.h
>  generic-y += mcs_spinlock.h
>  generic-y += user.h
> --- linux-next-20201208.orig/arch/nios2/include/asm/Kbuild
> +++ linux-next-20201208/arch/nios2/include/asm/Kbuild
> @@ -2,6 +2,7 @@
>  generic-y += cmpxchg.h
>  generic-y += extable.h
>  generic-y += kvm_para.h
> +generic-y += local64.h
>  generic-y += mcs_spinlock.h
>  generic-y += spinlock.h
>  generic-y += user.h

For nios2:

Acked-by: Ley Foon Tan <ley.foon.tan@xxxxxxxxx>

Regards
Ley Foon