Re: [PATCH 1/2] dt-bindings: add simple-audio-mux binding

From: Rob Herring
Date: Wed Dec 09 2020 - 21:06:46 EST


On Sat, Dec 05, 2020 at 01:15:07AM +0100, Alexandre Belloni wrote:
> Add devicetree documentation for simple audio multiplexers
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>
> ---
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>
>
> .../bindings/sound/simple-audio-mux.yaml | 41 +++++++++++++++++++
> 1 file changed, 41 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/sound/simple-audio-mux.yaml
>
> diff --git a/Documentation/devicetree/bindings/sound/simple-audio-mux.yaml b/Documentation/devicetree/bindings/sound/simple-audio-mux.yaml
> new file mode 100644
> index 000000000000..5986d1fcbb54
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/simple-audio-mux.yaml
> @@ -0,0 +1,41 @@
> +# SPDX-License-Identifier: (GPL-2.0+ OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/simple-audio-mux.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Simple Audio Multiplexer
> +
> +maintainers:
> + - Alexandre Belloni <aleandre.belloni@xxxxxxxxxxx>

typo

> +
> +description: |
> + Simple audio multiplexers are driven using gpios, allowing to select which of
> + their input line is connected to the output line.

What's wrong with the generic mux binding and driver(s)?

> +
> +properties:
> + compatible:
> + const: simple-audio-mux
> +
> + mux-gpios:
> + description: |
> + GPIOs used to select the input line.
> +
> + sound-name-prefix:
> + $ref: /schemas/types.yaml#/definitions/string
> + description:
> + Used as prefix for sink/source names of the component. Must be a
> + unique string among multiple instances of the same component.
> +
> +required:
> + - compatible
> + - mux-gpios
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + mux {
> + compatible = "simple-audio-mux";
> + mux-gpios = <&gpio 3 0>;
> + };
> --
> 2.28.0
>