Re: [PATCH 1/1] dt-bindings: leds: add onboard LED triggers of 96Boards

[Manivannan Sadhasivam]

Hi,

On Thu, Dec 10, 2020 at 11:12:03AM +0800, Zhen Lei wrote:
> For all 96Boards, the following standard is used for onboard LEDs.
> 
> green:user1  default-trigger: heartbeat
> green:user2  default-trigger: mmc0/disk-activity(onboard-storage)
> green:user3  default-trigger: mmc1 (SD-card)
> green:user4  default-trigger: none, panic-indicator
> yellow:wlan  default-trigger: phy0tx
> blue:bt      default-trigger: hci0-power
> 
> Link to 96Boards CE Specification: https://linaro.co/ce-specification
> 

This is just a board configuration and there is absolutely no need to document
this in common LED binding. But if your intention is to document the missing
triggers, then you should look at the patch I submitted long ago.

https://lore.kernel.org/patchwork/patch/1146359/

Maybe I should resubmit it again in YAML format. (thanks for reminding me :P)

Thanks,
Mani

> Signed-off-by: Zhen Lei <thunder.leizhen@xxxxxxxxxx>
> Cc: Darshak Patel <darshak.patel@xxxxxxxxxxxxxx>
> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
> Cc: Shawn Guo <shawnguo@xxxxxxxxxx>
> Cc: Dong Aisheng <aisheng.dong@xxxxxxx>
> Cc: Guodong Xu <guodong.xu@xxxxxxxxxx>
> Cc: Wei Xu <xuwei5@xxxxxxxxxxxxx>
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Cc: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> Cc: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@xxxxxxxxxxxxxx>
> Cc: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> Cc: Heiko Stuebner <heiko@xxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/leds/common.yaml | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
> index f1211e7045f12f3..525752d6c5c84fd 100644
> --- a/Documentation/devicetree/bindings/leds/common.yaml
> +++ b/Documentation/devicetree/bindings/leds/common.yaml
> @@ -97,6 +97,16 @@ properties:
>          # LED alters the brightness for the specified duration with one software
>          # timer (requires "led-pattern" property)
>        - pattern
> +        #For all 96Boards, Green, disk-activity(onboard-storage)
> +      - mmc0
> +        #For all 96Boards, Green, SD-card
> +      - mmc1
> +        #For all 96Boards, Green, panic-indicator
> +      - none
> +        #For all 96Boards, Yellow, WiFi activity LED
> +      - phy0tx
> +        #For all 96Boards, Blue, Bluetooth activity LED
> +      - hci0-power
>  
>    led-pattern:
>      description: |
> -- 
> 1.8.3
> 
>