Re: [PATCH] Revert "dm raid: remove unnecessary discard limits for raid10"

[kernel test robot]

Hi Song,

I love your patch! Perhaps something to improve:

[auto build test WARNING on dm/for-next]
[also build test WARNING on linux/master linus/master v5.10-rc7 next-20201209]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Song-Liu/Revert-dm-raid-remove-unnecessary-discard-limits-for-raid10/20201210-060948
base:   https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git for-next
config: x86_64-randconfig-s022-20201210 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-179-ga00755aa-dirty
        # https://github.com/0day-ci/linux/commit/c041d7bf65519d8a09a4193a0963fdcadcfd639b
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Song-Liu/Revert-dm-raid-remove-unnecessary-discard-limits-for-raid10/20201210-060948
        git checkout c041d7bf65519d8a09a4193a0963fdcadcfd639b
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>


"sparse warnings: (new ones prefixed by >>)"
>> drivers/md/dm-raid.c:3739:47: sparse: sparse: incompatible types in comparison expression (different signedness):
>> drivers/md/dm-raid.c:3739:47: sparse:    int *
>> drivers/md/dm-raid.c:3739:47: sparse:    unsigned int *

vim +3739 drivers/md/dm-raid.c

  3723	
  3724	static void raid_io_hints(struct dm_target *ti, struct queue_limits *limits)
  3725	{
  3726		struct raid_set *rs = ti->private;
  3727		unsigned int chunk_size_bytes = to_bytes(rs->md.chunk_sectors);
  3728	
  3729		blk_limits_io_min(limits, chunk_size_bytes);
  3730		blk_limits_io_opt(limits, chunk_size_bytes * mddev_data_stripes(rs));
  3731	
  3732		/*
  3733		 * RAID10 personality requires bio splitting,
  3734		 * RAID0/1/4/5/6 don't and process large discard bios properly.
  3735		 */
  3736		if (rs_is_raid10(rs)) {
  3737			limits->discard_granularity = max(chunk_size_bytes,
  3738							  limits->discard_granularity);
> 3739			limits->max_discard_sectors = min_not_zero(rs->md.chunk_sectors,
  3740								   limits->max_discard_sectors);
  3741		}
  3742	}
  3743	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip