RE: [PATCH] usb: cdns3: Fixed kernel test robot warning

[Pawel Laszczak]

>
>On 12/9/20 12:15 PM, Souptick Joarder wrote:
>> Kernel test robot throws below warning ->
>>
>> In file included from drivers/usb/cdns3/core.c:23:
>>>> drivers/usb/cdns3/host-export.h:27:51: warning: 'struct usb_hcd'
>>>> declared inside parameter list will not be visible outside of this
>>>> definition or declaration
>>       27 | static inline int xhci_cdns3_suspend_quirk(struct usb_hcd
>> *hcd)
>>          |                                                   ^~~~~~~
>>
>> This patch will silence it.
>
>Really?  Didn't silence it for me when I tested this patch.
>
>Also, please see
>
>https://urldefense.com/v3/__https://lore.kernel.org/linux-
>usb/DBBPR04MB7979502194410BB1AE96DF038BCC0@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/T/*m7f73fdd57c0f1577fb610dc
>af28646b53fa7dc26__;Iw!!EHscmS1ygiU1lA!XZzHlY6luEH3QepkggEsHS0x7oNNiz0XI9Xey3oIQpfSd1UVQEGzXbgXpfS2Eg$
>
>(what a strange URL)
>
>I now get these 2 warnings:
>
>In file included from ../drivers/usb/cdns3/core.c:23:0:
>../drivers/usb/cdns3/host-export.h:27:44: warning: ‘struct usb_hcd’ declared inside parameter list will not be visible outside of this
>definition or declaration
> static int xhci_cdns3_suspend_quirk(struct usb_hcd *hcd)
>                                            ^~~~~~~
>  CC [M]  drivers/usb/gadget/function/uvc_queue.o
>../drivers/usb/cdns3/host-export.h:27:12: warning: ‘xhci_cdns3_suspend_quirk’ defined but not used [-Wunused-function]
> static int xhci_cdns3_suspend_quirk(struct usb_hcd *hcd)
>            ^~~~~~~~~~~~~~~~~~~~~~~~
>

The best way for resolving this issue is to remove xhci_cdns3_suspend_quirk
from host-export.h file. It's used only in host.c file so it can be declared there
as static.

Thanks
Pawel

>
>> Reported-by: kernel test robot <lkp@xxxxxxxxx>
>> Signed-off-by: Souptick Joarder <jrdr.linux@xxxxxxxxx>
>> ---
>>  drivers/usb/cdns3/host-export.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/cdns3/host-export.h b/drivers/usb/cdns3/host-export.h
>> index fb8541b..c1259af 100644
>> --- a/drivers/usb/cdns3/host-export.h
>> +++ b/drivers/usb/cdns3/host-export.h
>> @@ -24,7 +24,7 @@ static inline int cdns_host_init(struct cdns *cdns)
>>  }
>>
>>  static inline void cdns_host_exit(struct cdns *cdns) { }
>> -static inline int xhci_cdns3_suspend_quirk(struct usb_hcd *hcd)
>> +static int xhci_cdns3_suspend_quirk(struct usb_hcd *hcd)
>>  {
>>  	return 0;
>>  }
>>
>
>
>--
>~Randy
>Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>