Re: [PATCH 1/1] dt-bindings: leds: add onboard LED triggers of 96Boards

[Manivannan Sadhasivam]

On Thu, Dec 10, 2020 at 02:14:57PM +0800, Leizhen (ThunderTown) wrote:
> 
> 
> On 2020/12/10 11:31, Manivannan Sadhasivam wrote:
> > Hi,
> > 
> > On Thu, Dec 10, 2020 at 11:12:03AM +0800, Zhen Lei wrote:
> >> For all 96Boards, the following standard is used for onboard LEDs.
> >>
> >> green:user1  default-trigger: heartbeat
> >> green:user2  default-trigger: mmc0/disk-activity(onboard-storage)
> >> green:user3  default-trigger: mmc1 (SD-card)
> >> green:user4  default-trigger: none, panic-indicator
> >> yellow:wlan  default-trigger: phy0tx
> >> blue:bt      default-trigger: hci0-power
> >>
> >> Link to 96Boards CE Specification: https://linaro.co/ce-specification
> >>
> > 
> > This is just a board configuration and there is absolutely no need to document
> > this in common LED binding. But if your intention is to document the missing
> No, I don't think so. The common just means the property linux,default-trigger
> is common, but not it values. This can be proved by counter-proving：none of
> the triggerrs currently defined in common.yaml is used by 96Boards.
> 

Right, but I was not happy with you mentioning 96Boards in the binding. Because
the triggers are used in more platforms other than 96Boards and they are not
specific to 96Boards. The documentation of triggers itself is fine.

> > triggers, then you should look at the patch I submitted long ago.
> 
> I'm just trying to eliminate the warnings related to Hisilicon that YAML detected.
> So I didn't pay attention to other missing triggers.
> 

No worries :)

> > 
> > https://lore.kernel.org/patchwork/patch/1146359/
> > 
> > Maybe I should resubmit it again in YAML format. (thanks for reminding me :P)
> 
> Yes, I hope that you will resubmit it. After all, these false positives are
> entirely due to YAML's failure to list all triggers. The DTS itself is fine.
> 
> By the way, the description of this patch I copied from your patch：
> 953d9f390365 arm64: dts: rockchip: Add on-board LED support on rk3399-rock960
> 
> That's why I Cc to you.
> 

I've now submitted the patch. Please take a look!

Thanks,
Mani

> > 
> > Thanks,
> > Mani
> > 
> >> Signed-off-by: Zhen Lei <thunder.leizhen@xxxxxxxxxx>
> >> Cc: Darshak Patel <darshak.patel@xxxxxxxxxxxxxx>
> >> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
> >> Cc: Shawn Guo <shawnguo@xxxxxxxxxx>
> >> Cc: Dong Aisheng <aisheng.dong@xxxxxxx>
> >> Cc: Guodong Xu <guodong.xu@xxxxxxxxxx>
> >> Cc: Wei Xu <xuwei5@xxxxxxxxxxxxx>
> >> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> >> Cc: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> >> Cc: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@xxxxxxxxxxxxxx>
> >> Cc: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> >> Cc: Heiko Stuebner <heiko@xxxxxxxxx>
> >> ---
> >>  Documentation/devicetree/bindings/leds/common.yaml | 10 ++++++++++
> >>  1 file changed, 10 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
> >> index f1211e7045f12f3..525752d6c5c84fd 100644
> >> --- a/Documentation/devicetree/bindings/leds/common.yaml
> >> +++ b/Documentation/devicetree/bindings/leds/common.yaml
> >> @@ -97,6 +97,16 @@ properties:
> >>          # LED alters the brightness for the specified duration with one software
> >>          # timer (requires "led-pattern" property)
> >>        - pattern
> >> +        #For all 96Boards, Green, disk-activity(onboard-storage)
> >> +      - mmc0
> >> +        #For all 96Boards, Green, SD-card
> >> +      - mmc1
> >> +        #For all 96Boards, Green, panic-indicator
> >> +      - none
> >> +        #For all 96Boards, Yellow, WiFi activity LED
> >> +      - phy0tx
> >> +        #For all 96Boards, Blue, Bluetooth activity LED
> >> +      - hci0-power
> >>  
> >>    led-pattern:
> >>      description: |
> >> -- 
> >> 1.8.3
> >>
> >>
> > 
> > .
> > 
>