Re: [PATCH net-next v7 4/5] net/x25: fix restart request/confirm handling

From: Martin Schiller
Date: Thu Dec 10 2020 - 01:29:20 EST


On 2020-12-09 23:11, Xie He wrote:
On Wed, Dec 9, 2020 at 1:47 AM Xie He <xie.he.0141@xxxxxxxxx> wrote:

On Wed, Dec 9, 2020 at 1:41 AM Martin Schiller <ms@xxxxxxxxxx> wrote:
>
> Right.
> By the way: A "Restart Collision" is in practice a very common event to
> establish the Layer 3.

Oh, I see. Thanks!

Hi Martin,

When you submit future patch series, can you try ensuring the code to
be in a completely working state after each patch in the series? This
makes reviewing the patches easier. After the patches get applied,
this also makes tracing bugs (for example, with "git bisect") through
the commit history easier.

Well I thought that's what patch series are for:
Send patches that belong together and should be applied together.

Of course I will try to make each patch work on its own, but this is not
always possible with major changes or ends up in monster patches.
And nobody wants that.

Martin