Re: [PATCH v3 1/7] dt-bindings: input: Add reset-time-sec common property
From: Cristian Ciocaltea
Date: Thu Dec 10 2020 - 04:14:36 EST
Hi Rob,
On Wed, Dec 09, 2020 at 09:37:08PM -0600, Rob Herring wrote:
> On Sun, Dec 06, 2020 at 03:27:01AM +0200, Cristian Ciocaltea wrote:
> > Add a new common property 'reset-time-sec' to be used in conjunction
> > with the devices supporting the key pressed reset feature.
> >
> > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@xxxxxxxxx>
> > ---
> > Changes in v3:
> > - This patch was not present in v2
> >
> > Documentation/devicetree/bindings/input/input.yaml | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/input/input.yaml b/Documentation/devicetree/bindings/input/input.yaml
> > index ab407f266bef..caba93209ae7 100644
> > --- a/Documentation/devicetree/bindings/input/input.yaml
> > +++ b/Documentation/devicetree/bindings/input/input.yaml
> > @@ -34,4 +34,11 @@ properties:
> > specify this property.
> > $ref: /schemas/types.yaml#/definitions/uint32
> >
> > + reset-time-sec:
>
> Humm, I'm pretty sure we already have something for this. Or maybe just
> power off.
We only have 'power-off-time-sec', so I added 'reset-time-sec' according
to your review in v2:
https://lore.kernel.org/lkml/20200908214724.GA959481@bogus/
Thanks,
Cristi
> > + description:
> > + Duration in seconds which the key should be kept pressed for device to
> > + reset automatically. Device with key pressed reset feature can specify
> > + this property.
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > +
> > additionalProperties: true
> > --
> > 2.29.2
> >