On Wed, Dec 9, 2020 at 2:17 PM Milan Lakhani
<milan.lakhani@xxxxxxxxxxxxxxx> wrote:
In trace_uprobe.c, trace_uprobe_create assigns ret to 0 but then neverMilan, the patch makes sense, but I fear you did not run
uses this value.
./scripts/get_maintainers.pl because you did not include any specific
maintainer as recipient.
The patch subject could be: remove unneeded initialization (instead ofUpdated this, thanks
the very generic "dead store" term).
It is also interesting to see who added this initialization; was it
unneeded since the existence of this function, did it become obsolete
at some point in time due to refactoring?
Run ./scripts/get_maintainers.pl and please CC: me; then you will get
your Reviewed-by: tag.
Lukas
Signed-off-by: Milan Lakhani <milan.lakhani@xxxxxxxxxxxxxxx>
---
kernel/trace/trace_uprobe.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
index 3cf7128..c7c7070 100644
--- a/kernel/trace/trace_uprobe.c
+++ b/kernel/trace/trace_uprobe.c
@@ -541,7 +541,6 @@ static int trace_uprobe_create(int argc, const char **argv)
bool is_return = false;
int i, ret;
- ret = 0;
ref_ctr_offset = 0;
switch (argv[0][0]) {
--
2.7.4