Re: Re: Re: [PATCH] staging: rtl8712: check register_netdev() return value

From: shaojie . dong
Date: Thu Dec 10 2020 - 10:23:25 EST


Hi

I do not have rtl8712 hardware
So that I would remain this code and give up my patch
Thank you !

> -----原始邮件-----
&gt; 发件人: "Dan Carpenter" <dan.carpenter@xxxxxxxxxx>
&gt; 发送时间: 2020-12-10 23:16:31 (星期四)
&gt; 收件人: shaojie.dong@xxxxxxxxxxxxxxxx
&gt; 抄送: Larry.Finger@xxxxxxxxxxxx, florian.c.schilhabel@xxxxxxxxxxxxxx, gregkh@xxxxxxxxxxxxxxxxxxx, devel@xxxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
&gt; 主题: Re: Re: [PATCH] staging: rtl8712: check register_netdev() return value
&gt;
&gt; On Thu, Dec 10, 2020 at 11:05:34PM +0800, shaojie.dong@xxxxxxxxxxxxxxxx wrote:
&gt; &gt; Hi
&gt; &gt;
&gt; &gt; &gt;
&gt; &gt; &gt; This function should not be calling register_netdev(). What does that
&gt; &gt; &gt; have to do with firmware? It should also not free_netdev() because
&gt; &gt; &gt; that will just lead to a use after free in the caller.
&gt; &gt; &gt;
&gt; &gt;
&gt; &gt; --&gt; check code history author<larry.finger@xxxxxxxxxxxx> changed synchronous firmware loading to asynchronous firmware loading
&gt; &gt; before this change, register_netdev() was not calling in firmware related function.
&gt; &gt; For asynchronous loading, maybe register_netdev() be calling in rtl871x_load_fw_cb() is to ensure the netdev be registered after firmware loading completed
&gt; &gt;
&gt; &gt; --&gt; for potential use after free issue
&gt; &gt; Could I only call "free_irq(adapter-&gt;pnetdev-&gt;irq, adapter-&gt;pnetdev)" when register_netdev() failed ?
&gt; &gt; If no need to change drivers/staging/rtl8712/hal_init.c file, I could give up my patch, thank you !
&gt; &gt;
&gt;
&gt; Cleaning this up is a bit complicated and requires reworking the
&gt; firmware loading and it requires testing. I don't think you have the
&gt; hardware to actually test this driver? Probably, just leave this code
&gt; for another day.
&gt;
&gt; regards,
&gt; dan carpenter
</larry.finger@xxxxxxxxxxxx></dan.carpenter@xxxxxxxxxx>