Re: [PATCH 1/2] rcu-tasks: move RCU-tasks initialization out of core_initcall()
From: Paul E. McKenney
Date: Thu Dec 10 2020 - 12:34:35 EST
On Fri, Dec 11, 2020 at 12:39:21AM +1100, Daniel Axtens wrote:
> Hi Vlad,
>
> >> Initialize the RCU-tasks earlier, before *_initcall() callbacks are
> >> invoked. Do it after the workqueue subsytem is up and running. That
> >> gives us a possibility to make use of synchronize_rcu_tasks*() wait
> >> API in early_initcall() callbacks.
> >>
> >> Fixes: 36dadef23fcc ("kprobes: Init kprobes in early_initcall")
> >> Signed-off-by: Uladzislau Rezki (Sony) <urezki@xxxxxxxxx>
>
> Tested-by: Daniel Axtens <dja@xxxxxxxxxx>
I will apply on the next rebase, thank you!
Thanx, Paul
> >> ---
> >> include/linux/rcupdate.h | 6 ++++++
> >> init/main.c | 1 +
> >> kernel/rcu/tasks.h | 26 ++++++++++++++++++++++----
> >> 3 files changed, 29 insertions(+), 4 deletions(-)
> >>
> > I still don't have a powerPC hw so far, even though i have sent a request
> > to the osuosl.org. It would be appreciated if Michael or Daniel could run
> > and verify it.
>
> Sorry it's taken me so long to get to this. Your patch fixes things for
> me. Thanks!
>
> BTW, I'm happy to see you taking on the challenge of RCU after your good
> work on vmalloc - all the best with it!
>
> Kind regards,
> Daniel
>
> >
> > Thank you in advance!
> >
> > --
> > Vlad Rezki