Re: [PATCH 1/2] clk: qcom: gcc-sc7180: Use floor ops for sdcc clks

From: Stephen Boyd
Date: Thu Dec 10 2020 - 15:29:17 EST


Quoting Douglas Anderson (2020-12-10 10:22:38)
> I would repeat the same commit message that was in commit 5e4b7e82d497
> ("clk: qcom: gcc-sdm845: Use floor ops for sdcc clks") but it seems
> silly to do so when you could just go read that commit.
>
> NOTE: this is actually extra terrible because we're missing the 50 MHz
> rate in the table (see the next patch AKA ("clk: qcom: gcc-sc7180: Add
> 50 MHz clock rate for SDC2")). That means then when you run an older
> SD card it'll try to clock it at 100 MHz when it's only specced to run
> at 50 MHz max. As you can probably guess that doesn't work super
> well.
>
> Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
> Fixes: 17269568f726 ("clk: qcom: Add Global Clock controller (GCC) driver for SC7180")
> ---

Applied to clk-next