Re: [PATCH v2] usb: typec: Add class for plug alt mode device

From: Benson Leung
Date: Thu Dec 10 2020 - 18:19:36 EST


Hi Prashant,

On Thu, Dec 10, 2020 at 01:16:54PM -0800, Prashant Malani wrote:
> Add the Type C class for plug alternate mode devices which are being
> registered by the Type C connector class. This ensures that udev events
> get generated when the plug alt modes are registered.
>
> Signed-off-by: Prashant Malani <pmalani@xxxxxxxxxxxx>
> Cc: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>

Reviewed-by: Benson Leung <bleung@xxxxxxxxxxxx>


> ---
>
> Changes in v2:
> - Changed code to set the class member instead of bus.
> - Removed the alteration to typec_bus.rst since it's not longer
> required.
> - Updated the commit message and subject to reflect the change in code.
>
> v1: https://lore.kernel.org/linux-usb/20201203030846.51669-1-pmalani@xxxxxxxxxxxx/
>
> drivers/usb/typec/class.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c
> index 35eec707cb51..29d05b45cc9d 100644
> --- a/drivers/usb/typec/class.c
> +++ b/drivers/usb/typec/class.c
> @@ -482,6 +482,10 @@ typec_register_altmode(struct device *parent,
> if (is_typec_partner(parent))
> alt->adev.dev.bus = &typec_bus;
>
> + /* Plug alt modes need a class to generate udev events. */
> + if (is_typec_plug(parent))
> + alt->adev.dev.class = typec_class;
> +
> ret = device_register(&alt->adev.dev);
> if (ret) {
> dev_err(parent, "failed to register alternate mode (%d)\n",
> --
> 2.29.2.576.ga3fc446d84-goog
>

--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@xxxxxxxxxx
Chromium OS Project
bleung@xxxxxxxxxxxx

Attachment: signature.asc
Description: PGP signature