RE: [PATCH] ath10k: Remove voltage regulator votes during wifi disable

[Rakesh Pillai]

> -----Original Message-----
> From: Brian Norris <briannorris@xxxxxxxxxxxx>
> Sent: Thursday, December 10, 2020 11:44 PM
> To: Rakesh Pillai <pillair@xxxxxxxxxxxxxx>
> Cc: ath10k <ath10k@xxxxxxxxxxxxxxxxxxx>; linux-wireless <linux-
> wireless@xxxxxxxxxxxxxxx>; Linux Kernel <linux-kernel@xxxxxxxxxxxxxxx>;
> Doug Anderson <dianders@xxxxxxxxxxxx>; kuabhs@xxxxxxxxxxxx;
> Youghandhar Chintala <youghand@xxxxxxxxxxxxxx>
> Subject: Re: [PATCH] ath10k: Remove voltage regulator votes during wifi
> disable
> 
> On Thu, Dec 10, 2020 at 7:09 AM Rakesh Pillai <pillair@xxxxxxxxxxxxxx>
> wrote:
> > --- a/drivers/net/wireless/ath/ath10k/snoc.c
> > +++ b/drivers/net/wireless/ath/ath10k/snoc.c
> > @@ -1045,14 +1085,18 @@ static int ath10k_snoc_hif_power_up(struct
> ath10k *ar,
> >         ret = ath10k_snoc_init_pipes(ar);
> >         if (ret) {
> >                 ath10k_err(ar, "failed to initialize CE: %d\n", ret);
> > -               goto err_wlan_enable;
> > +               goto err_free_rri;
> >         }
> >
> >         return 0;
> >
> > -err_wlan_enable:
> > +err_free_rri:
> > +       ath10k_ce_free_rri(ar);
> 
> This change in the error path seems to be an unrelated (but correct)
> fix. It deserves its own patch, I think.

Sure Brian. I will post this error handling fix as a separate patch, and also post a v2 for this patchset.