Re: [PATCH] spi: dt-bindings: clarify CS behavior for spi-cs-high and gpio descriptors

From: Linus Walleij
Date: Fri Dec 11 2020 - 03:14:21 EST


On Wed, Dec 9, 2020 at 11:01 AM H. Nikolaus Schaller <hns@xxxxxxxxxxxxx> wrote:

> Behavior of CS signal in combination of spi-cs-high and gpio descriptors
> is not clearly defined and documented. So clarify the documentation
>
> Cc: linus.walleij@xxxxxxxxxx
> Cc: linux-gpio@xxxxxxxxxxxxxxx
> Signed-off-by: H. Nikolaus Schaller <hns@xxxxxxxxxxxxx>

This is good because it is helpful to users.
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

In cases like this I would actually consider to write a bit in the
bindings saying "this is inconsistent because we screwed up
so be careful", standard bodies usually try to avoid that kind of
statements because they have all kind of prestige involved
with their work, but we don't so we can just as well admit it.

Yours,
Linus Walleij