Re: [PATCH 4.19 15/39] ALSA: hda/generic: Add option to enforce preferred_dacs pairs

From: Pavel Machek
Date: Fri Dec 11 2020 - 03:38:35 EST


Hi!

> From: Takashi Iwai <tiwai@xxxxxxx>
>
> commit 242d990c158d5b1dabd166516e21992baef5f26a upstream.
>
> The generic parser accepts the preferred_dacs[] pairs as a hint for
> assigning a DAC to each pin, but this hint doesn't work always
> effectively. Currently it's merely a secondary choice after the trial
> with the path index failed. This made sometimes it difficult to
> assign DACs without mimicking the connection list and/or the badness
> table.
>
> This patch adds a new flag, obey_preferred_dacs, that changes the
> behavior of the parser. As its name stands, the parser obeys the

Option added is never used as variable is never set. We don't need
this in 4.19.

Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Attachment: signature.asc
Description: PGP signature