Re: [PATCH -next] char/tpm: simplify the return expression of tpm_tis_synquacer_module_init()
From: Jarkko Sakkinen
Date: Fri Dec 11 2020 - 05:55:56 EST
On Thu, Dec 10, 2020 at 09:55:15PM +0800, Zheng Yongjun wrote:
> Simplify the return expression.
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@xxxxxxxxxx>
I don't see how this would be meaningful change as the existing
code is according to the coding style.
> ---
> drivers/char/tpm/tpm_tis_synquacer.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/char/tpm/tpm_tis_synquacer.c b/drivers/char/tpm/tpm_tis_synquacer.c
> index e47bdd272704..3b4ae2f23f09 100644
> --- a/drivers/char/tpm/tpm_tis_synquacer.c
> +++ b/drivers/char/tpm/tpm_tis_synquacer.c
> @@ -188,13 +188,8 @@ static struct platform_driver tis_synquacer_drv = {
>
> static int __init tpm_tis_synquacer_module_init(void)
> {
> - int rc;
>
> - rc = platform_driver_register(&tis_synquacer_drv);
> - if (rc)
> - return rc;
> -
> - return 0;
> + return platform_driver_register(&tis_synquacer_drv);
> }
>
> static void __exit tpm_tis_synquacer_module_exit(void)
> --
> 2.22.0
>
>
/Jarkko