Re: [PATCH v2 1/3] KVM: x86: implement KVM_{GET|SET}_TSC_STATE

From: Paolo Bonzini
Date: Fri Dec 11 2020 - 08:39:52 EST


On 11/12/20 01:27, Marcelo Tosatti wrote:
This features first, correctness later frenzy is insane and it better
stops now before you pile even more crap on the existing steaming pile
of insanities.

FWIW I agree, in fact I wish I knew exactly where to start simplifying it; the timekeeping code in KVM is perhaps the last remaining bastion where I'm afraid just to look at it.

At least I know there's a couple of features that IMHO are completely useless, and that's even before you reach the ones that might "only" be obsolete. So perhaps that's where to start, together with the messiest userspace interfaces.

Paolo