Re: [PATCH 2/2] usb: dwc3: drd: Avoid error when extcon is missing
From: Andy Shevchenko
Date: Fri Dec 11 2020 - 09:18:17 EST
On Thu, Dec 10, 2020 at 10:33:18PM +0200, Sam Protsenko wrote:
> If "port" node is missing in PHY controller node, dwc3_get_extcon()
> isn't able to find extcon device. This is perfectly fine in case when
> "usb-role-switch" or OTG is used, but next misleading error message is
> printed in that case, from of_graph_get_remote_node():
>
> OF: graph: no port node found in /phy@1234abcd
>
> Avoid printing that message by checking if port node exists in PHY node
> before calling of_graph_get_remote_node().
By some reason you have two separate messages (missed --thread when run `git
format-patch ...`?).
In any case I think it should be dropped or reworked and resent since patch 1/2
got comments.
--
With Best Regards,
Andy Shevchenko