Re: [PATCH net-next v3 2/4] vm_sockets: Add VMADDR_FLAG_TO_HOST vsock flag

[Stefano Garzarella]

On Fri, Dec 11, 2020 at 12:32:39PM +0200, Andra Paraschiv wrote:
> Add VMADDR_FLAG_TO_HOST vsock flag that is used to setup a vsock
> connection where all the packets are forwarded to the host.
>
> Then, using this type of vsock channel, vsock communication between
> sibling VMs can be built on top of it.
>
> Changelog
>
> v2 -> v3
>
> * Update comments to mention when the flag is set in the connect and
>  listen paths.
>
> v1 -> v2
>
> * New patch in v2, it was split from the first patch in the series.
> * Remove the default value for the vsock flags field.
> * Update the naming for the vsock flag to "VMADDR_FLAG_TO_HOST".
>
> Signed-off-by: Andra Paraschiv <andraprs@xxxxxxxxxx>
> ---
> include/uapi/linux/vm_sockets.h | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)

Reviewed-by: Stefano Garzarella <sgarzare@xxxxxxxxxx>

> diff --git a/include/uapi/linux/vm_sockets.h b/include/uapi/linux/vm_sockets.h
> index 619f8e9d55ca4..c99ed29602345 100644
> --- a/include/uapi/linux/vm_sockets.h
> +++ b/include/uapi/linux/vm_sockets.h
> @@ -114,6 +114,26 @@
>
> #define VMADDR_CID_HOST 2
>
> +/* The current default use case for the vsock channel is the following:
> + * local vsock communication between guest and host and nested VMs setup.
> + * In addition to this, implicitly, the vsock packets are forwarded to the host
> + * if no host->guest vsock transport is set.
> + *
> + * Set this flag value in the sockaddr_vm corresponding field if the vsock
> + * packets need to be always forwarded to the host. Using this behavior,
> + * vsock communication between sibling VMs can be setup.
> + *
> + * This way can explicitly distinguish between vsock channels created for
> + * different use cases, such as nested VMs (or local communication between
> + * guest and host) and sibling VMs.
> + *
> + * The flag can be set in the connect logic in the user space application flow.
> + * In the listen logic (from kernel space) the flag is set on the remote peer
> + * address. This happens for an incoming connection when it is routed from the
> + * host and comes from the guest (local CID and remote CID > VMADDR_CID_HOST).
> + */
> +#define VMADDR_FLAG_TO_HOST 0x0001
> +
> /* Invalid vSockets version. */
>
> #define VM_SOCKETS_INVALID_VERSION -1U
> --
> 2.20.1 (Apple Git-117)
>
>
>
>
> Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.