Re: [PATCH RESEND v8 3/4] input: elants: read touchscreen size for EKTF3624

[Michał Mirosław]

On Thu, Dec 10, 2020 at 11:22:09PM -0800, Dmitry Torokhov wrote:
> Hi Michał,
> 
> On Fri, Dec 11, 2020 at 07:53:56AM +0100, Michał Mirosław wrote:
> > +
> > +	if (!phy_x || !phy_y) {
> > +		dev_warn(&client->dev,
> > +			 "invalid size data: %d x %d mm\n",
> > +			 phy_x, phy_y);
> > +		return 0;
> 
> Given we are not treating this as hard error mind dropping this "return"
> and making the below an "else" branch?

It is an error, still, and saves a bit of indentation in the following
normal-path code. But I see that there is already a similar code with
an 'else' branch.

Best Regards,
Michał Mirosław