Re: [PATCH v3 1/4] dt-bindings: mtd: partitions: Add binding for Qcom SMEM parser

[Rob Herring]

On Fri, Dec 11, 2020 at 09:01:40AM +0530, Manivannan Sadhasivam wrote:
> On Mon, Dec 07, 2020 at 03:52:36PM -0600, Rob Herring wrote:
> > On Thu, Nov 19, 2020 at 12:43:05PM +0530, Manivannan Sadhasivam wrote:
> > > Add YAML binding for Qualcomm Shared Memory (SMEM) Flash partition
> > > parser.
> > > 
> > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
> > > ---
> > >  .../mtd/partitions/qcom,smem-part.yaml        | 33 +++++++++++++++++++
> > >  1 file changed, 33 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/mtd/partitions/qcom,smem-part.yaml
> > > 
> > > diff --git a/Documentation/devicetree/bindings/mtd/partitions/qcom,smem-part.yaml b/Documentation/devicetree/bindings/mtd/partitions/qcom,smem-part.yaml
> > > new file mode 100644
> > > index 000000000000..cf3f8c1e035d
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/mtd/partitions/qcom,smem-part.yaml
> > > @@ -0,0 +1,33 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/mtd/partitions/qcom,smem-part.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Qualcomm SMEM NAND flash partition parser binding
> > > +
> > > +maintainers:
> > > +  - Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
> > > +
> > > +description: |
> > > +  The Qualcomm SoCs supporting the NAND controller interface features a Shared
> > > +  Memory (SMEM) based partition table scheme. The maximum partitions supported
> > > +  varies between partition table revisions. V3 supports maximum 16 partitions
> > > +  and V4 supports 48 partitions.
> > 
> > V3 vs. V4 (and any other version for that matter) is discoverable?
> > 
> 
> Yes, it is discoverable based on the partition header and we do that in
> the parser.

Okay,

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>

> 
> Thanks,
> Mani
> 
> > > +
> > > +properties:
> > > +  compatible:
> > > +    const: qcom,smem-part
> > > +
> > > +required:
> > > +  - compatible
> > > +
> > > +additionalProperties: false
> > > +
> > > +examples:
> > > +  - |
> > > +    flash {
> > > +        partitions {
> > > +            compatible = "qcom,smem-part";
> > > +        };
> > > +    };
> > > -- 
> > > 2.17.1
> > >