Re: [PATCH -next] platform: surface: fix non-PM_SLEEP build warnings

[Andy Shevchenko]

On Fri, Dec 11, 2020 at 9:20 PM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
>
> Fix build warnings when CONFIG_PM_SLEEP is not enabled and these
> functions are not used:
>
> ../drivers/platform/surface/surface_gpe.c:189:12: warning: ‘surface_gpe_resume’ defined but not used [-Wunused-function]
>  static int surface_gpe_resume(struct device *dev)
>             ^~~~~~~~~~~~~~~~~~
> ../drivers/platform/surface/surface_gpe.c:184:12: warning: ‘surface_gpe_suspend’ defined but not used [-Wunused-function]
>  static int surface_gpe_suspend(struct device *dev)
>             ^~~~~~~~~~~~~~~~~~~

...

> +#ifdef CONFIG_PM_SLEEP
>  static int surface_gpe_suspend(struct device *dev)

Perhaps __maybe_unused ?

-- 
With Best Regards,
Andy Shevchenko